Expose missing data-disabled and data-focus attributes on the TabsPanel, MenuButton, PopoverButton and DisclosureButton components
#3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
force-pushed
the
feat/expose-more-data-attributes
branch
from
e6016c7 to
03d5f30
Compare
RobinMalfait
changed the title
data-disabled and data-focus attributes on the TabsPanel, MenuButton, PopoverButton and DisclosureButton components
thecrypticace
approved these changes
Mar 27, 2024
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes more data attributes on some components, mainly:
data-focuson theTabsPanelcomponentdata-disabledon theMenuButtoncomponentdata-disabledon thePopoverButtoncomponentdata-disabledon theDisclosureButtoncomponentThis PR also cleans up some repetition on related to this, because in some places we used
props.autoFocus ?? falseorprops.disabled ?? falsein multiple spots. Now, this is destructured from the props object with a fallback.