Close the Combobox, Dialog, Listbox, Menu and Popover components when the trigger disappears
#3075
+69
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
force-pushed
the
feat/close-components-on-disappear
branch
from
1073680 to
e8106d2
Compare
RobinMalfait
changed the title
Menu, Listbox, Popover and Dialog components when the triggers disappearMenu, Listbox, Popover and Dialog components when the trigger disappears
reinink
reviewed
Apr 3, 2024
| @@ -33,6 +33,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Accept optional `strategy` for the `anchor` prop ([#3034](https://github.com/tailwindlabs/headlessui/pull/3034)) | |||
| - Expose `--input-width` and `--button-width` CSS variables on the `ComboboxOptions` component ([#3057](https://github.com/tailwindlabs/headlessui/pull/3057)) | |||
| - Expose the `--button-width` CSS variable on the `PopoverPanel` component ([#3058](https://github.com/tailwindlabs/headlessui/pull/3058)) | |||
| - Close the `Menu`, `Listbox`, `Popover` and `Dialog` components when the trigger disappears ([#3075](https://github.com/tailwindlabs/headlessui/pull/3075)) | |||
There was a problem hiding this comment.
Alphabetical 🤷♂️
Suggested change
| - Close the `Menu`, `Listbox`, `Popover` and `Dialog` components when the trigger disappears ([#3075](https://github.com/tailwindlabs/headlessui/pull/3075)) | |
| - Close the `Dialog`, `Listbox`, `Menu`, and `Popover` components when the trigger disappears ([#3075](https://github.com/tailwindlabs/headlessui/pull/3075)) |
There was a problem hiding this comment.
Just thinking — should this behavior not be added to the Combobox as well?
There was a problem hiding this comment.
I completely missed this one, 100% should be added there as well!
reinink
requested changes
Apr 3, 2024
RobinMalfait
changed the title
Menu, Listbox, Popover and Dialog components when the trigger disappearsCombobox, Dialog, Listbox, Menu and Popover components when the trigger disappears
RobinMalfait
force-pushed
the
feat/close-components-on-disappear
branch
from
9a6e17e to
c9f9182
Compare
reinink
approved these changes
Apr 3, 2024
This hook allows us to trigger a callback if the element becomes "hidden". We use the bounding client rect and check the dimensions to know wether we are "hidden" or not.
RobinMalfait
force-pushed
the
feat/close-components-on-disappear
branch
from
c9f9182 to
67243b9
Compare
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will ensure that we don't have any floating panels when the trigger elements disappear. We already had this implementation for the
Dialogcomponent, but now this is implemented for all components that have ananchorprop.The big problem is that with the
anchorprop, each panel (e.g.:MenuItems,ListboxOptions, …) is portalled and positioned relative to theanchorelement. If theanchorelement disappears, the panel will still be rendered and strangely positioned in the DOM, which is not the desired behavior.This PR solves that by:
Combobox, when theComboboxInputdisappearsDialog, when theDialogitself disappears (this was already implemented, but now it's using the newuseOnDisappearhook)Listbox, when theListboxButtondisappearsMenu, when theMenuButtondisappearsPopover, when thePopoverPaneldisappears