Prevent closing the Combobox component when clicking inside the scrollbar area
#3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thecrypticace
approved these changes
Apr 16, 2024
RobinMalfait
added a commit
that referenced
this pull request
Apr 16, 2024
…ollbar area (#3104) * prevent closing `Combobox` when clicking inside the scrollbar area * update changelog
This was referenced May 18, 2024
This was referenced May 25, 2024
|
@RobinMalfait This PR breaks the following scenario: a Combobox with an input field inside. When I now click the input field, the click is now regarded as a ComboboxOption selection instead of just focusing the input field. 
In 1.7.20 the following code used to work, but starting from 1.7.21 it broke. Removing the enclosing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that clicking inside the scrollbar area of the
ComboboxOptionsdoes not close theCombobox.The main issue (see #3071) is that clicking inside the scrollbar area moves focus into the
TabPanelwhich blurs theComboboxInputand in turn closes theCombobox.Preventing the default behavior of the
mousedownevent when clicking inside the scrollbar area of theComboboxOptionsprevents the focus from moving to theTabPaneland keeps theComboboxopen.Fixes: #3071