Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure TransitionRoot component without props transitions correctly #3147

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Ensure TransitionRoot component without props transitions correctly #3147

merged 2 commits into from
Apr 26, 2024

Commits on Apr 26, 2024

  1. ensure TransitionRoot component without props transitions correctly 

    A bit of a weird one, but you can use the `TransitionRoot` component
without any props for transitions themselves (so no real transition can
happen). Even crazier, it can happen that it doesn't even render a DOM
node, but just its children.

At this point, the `TransitionRoot` component is purely there for
orchestration purposes of child components.

Since there is no DOM node in certain situations, the transitions (and
its `onStart` and `onStop` callbacks) won't even happen at all. This
causes a bug (obvious in react strict mode) where children don't
properly mount or the transition component doesn't properly unmount.
    @RobinMalfait
    RobinMalfait committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    46aa359 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @RobinMalfait
    RobinMalfait committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    34c759c View commit details
    Browse the repository at this point in the history