Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when toggling between virtual and non-virtual mode in Combobox component #3236

Merged
merged 7 commits into from
May 24, 2024
Merged

Fix crash when toggling between virtual and non-virtual mode in Combobox component #3236

merged 7 commits into from
May 24, 2024

Commits on May 24, 2024

  1. ensure we correctly merge the virtual configuration

    @RobinMalfait
    RobinMalfait committed May 24, 2024
    Configuration menu
    Copy the full SHA
    a240130 View commit details
    Browse the repository at this point in the history

  2. use more generic UpdateVirtualOptions 

    This way we can passthrough the `disabled` function as well.
    @RobinMalfait
    RobinMalfait committed May 24, 2024
    Configuration menu
    Copy the full SHA
    3efd657 View commit details
    Browse the repository at this point in the history

  3. properly handle re-use of disabled function

    @RobinMalfait
    RobinMalfait committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1c491c9 View commit details
    Browse the repository at this point in the history

  4. use same order in objects

    @RobinMalfait
    RobinMalfait committed May 24, 2024
    Configuration menu
    Copy the full SHA
    599da62 View commit details
    Browse the repository at this point in the history

  5. cleanup ! and ? if we already know we are in virtual mode

    @RobinMalfait
    RobinMalfait committed May 24, 2024
    Configuration menu
    Copy the full SHA
    8458d37 View commit details
    Browse the repository at this point in the history

  6. directly enable virtual mode in state if previously we weren't using … 

    …virtual mode
    @RobinMalfait
    RobinMalfait committed May 24, 2024
    Configuration menu
    Copy the full SHA
    6df87f8 View commit details
    Browse the repository at this point in the history

  7. update changelog

    @RobinMalfait
    RobinMalfait committed May 24, 2024
    Configuration menu
    Copy the full SHA
    ca1943f View commit details
    Browse the repository at this point in the history