Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel outside click behavior on touch devices when scrolling #3266

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Cancel outside click behavior on touch devices when scrolling #3266

merged 6 commits into from
Jun 3, 2024

Commits on Jun 3, 2024

  1. make handleOutsideClick stable

    @RobinMalfait
    RobinMalfait committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    f70dc65 View commit details
    Browse the repository at this point in the history

  2. cancel "outside click" when "scrolling" on touch device 

    When on a touch device, then the `touchend` event will fire, even if you
scrolled a bit and scrolling was your intention.

This now tracks that touches were at least 30px apart in either the X or
Y direction. If that's the case, then we do not consider it an outside
click.
    @RobinMalfait
    RobinMalfait committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    d5e7c07 View commit details
    Browse the repository at this point in the history

  3. add enabled parameter to useDocumentEvent and useWindowEvent

    @RobinMalfait
    RobinMalfait committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b1a338e View commit details
    Browse the repository at this point in the history

  4. update useDocumentEvent and useWindowEvent usages 

    This now takes the new `enabled` value into account.
    @RobinMalfait
    RobinMalfait committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b5b7ddd View commit details
    Browse the repository at this point in the history

  5. update changelog

    @RobinMalfait
    RobinMalfait committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    0884ba9 View commit details
    Browse the repository at this point in the history

  6. bump vue and vite in playground

    @RobinMalfait
    RobinMalfait committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    15e5e70 View commit details
    Browse the repository at this point in the history