Remove transition state from render props #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of in the `slot` because this would also expose this information as render props but we just want to set it as props without exposing it as render props.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thecrypticace
requested changes
Jun 21, 2024
| @@ -463,6 +463,7 @@ function TransitionChildFn<TTag extends ElementType = typeof DEFAULT_TRANSITION_ | |||
| // Map data attributes to `entered` class (backwards compatibility) | |||
| !slot.transition && show && entered | |||
| )?.trim() || undefined, // If `className` is an empty string, we can omit it | |||
| ...transitionDataAttributes(slot), | |||
There was a problem hiding this comment.
We should probably rename slot to transitionData just so we don't accidentally add this back
RobinMalfait
commented
Jun 21, 2024
packages/@headlessui-react/src/components/transition/transition.tsx
Outdated
Show resolved
Hide resolved
thecrypticace
approved these changes
Jun 21, 2024
RobinMalfait
changed the title
This was referenced Jul 13, 2024
This was referenced Jul 27, 2024
This was referenced Aug 29, 2024
This was referenced Sep 6, 2024
This was referenced Sep 10, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that the transition data, such as
closed,enter,leaveandtransitionis only mapped as data attributes e.g.:data-closed.This PR removes the information from the render prop.