Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add value type generic to ComboboxOptionsProp #3394

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add value type generic to ComboboxOptionsProp #3394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/@headlessui-react/src/components/combobox/combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1589,17 +1589,20 @@ function ButtonFn<TTag extends ElementType = typeof DEFAULT_BUTTON_TAG>(
// ---

let DEFAULT_OPTIONS_TAG = 'div' as const
type OptionsRenderPropArg = {
type OptionsRenderPropArg<TValue = any> = {
open: boolean
option: any
option: TValue
}
type OptionsPropsWeControl = 'aria-labelledby' | 'aria-multiselectable' | 'role' | 'tabIndex'

let OptionsRenderFeatures = RenderFeatures.RenderStrategy | RenderFeatures.Static

export type ComboboxOptionsProps<TTag extends ElementType = typeof DEFAULT_OPTIONS_TAG> = Props<
export type ComboboxOptionsProps<
TTag extends ElementType = typeof DEFAULT_OPTIONS_TAG,
TValue = any,
> = Props<
TTag,
OptionsRenderPropArg,
OptionsRenderPropArg<TValue>,
OptionsPropsWeControl,
PropsForFeatures<typeof OptionsRenderFeatures> & {
hold?: boolean
Expand Down
Loading