add enableScrollLock prop to dialog component #850
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support an additional property to the
Dialog
component namedenableScrollLock
. If this property is not set, it will default totrue
(maintaining backward compatibility), but if it is set tofalse
, it will inhibit changing theoverflow
andpaddingRight
settings on the of thebody
tag's style.This has been the number one requested user-experience change to my application which utilizes the
Dialog
component. In some cases, it is helpful to be able to scroll the page below the dialog.