Add support for new loadModule and loadStylesheet APIs from v4
#317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
loadModule and loadStylesheet APIs from v4
thecrypticace
force-pushed
the
feat/v4-load-stylesheet
branch
3 times, most recently
from
7fac133 to
6e741ac
Compare
thecrypticace
force-pushed
the
feat/v4-load-stylesheet
branch
from
6e741ac to
a8693bd
Compare
philipp-spiess
approved these changes
Sep 24, 2024
Comment on lines
+226
to
+230
| if (!supportsImports) { | ||
| let resolveImports = postcss([postcssImport()]) | ||
| let result = await resolveImports.process(css, { from: entryPoint }) | ||
| css = result.css | ||
| } |
There was a problem hiding this comment.
Nice that we can already shave off some work here too 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to tailwindlabs/tailwindcss#14446
We'll be handling
@importresolution in core with the appropriate hooks to ensure that all I/O is done outside of the core package. This PR preps for that.