-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugins.ts to support zackad/prettier-plugin-twig #327
base: main
Are you sure you want to change the base?
Conversation
@bitbirddev thank you for this! 🙏 @thecrypticace please I haven't been able to update the plugin for a while due to this simple change not being implemented yet, could you please take a look and merge this PR if poissible? References: Thank you |
@adamwathan Please could you review this? |
The tests in this PR are currently failing — we've been focused on some other things so I haven't looked into why yet. That's the biggest reason this hasn't been merged. |
@bitbirddev @zackad can you fix the tests to allow @thecrypticace to merge this PR? |
I don't even know what the problem is. Been tinkering in the last few weeks. I can't even make the test pass from main branch in my setup. I use NixOS and macos with home-manager, same result. When using docker, the test fail only when loading twig plugin. Sorry but I don't have patient to debug on docker setup. In the meantime, I use my own custom build of this plugin with patch 521576a applied on top. |
resolves #254