Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect spaces around - in calc() expression #12283

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Conversation

RobinMalfait
Copy link
Member

This PR fixes a bug where incorrect spaces were added around - in calc() expressions. This is
happening in places like:

  • minmax(min-content,25%) -> minmax(min - content,25%)
  • calc(env(safe-area-inset-bottom,20px)) -> calc(env(safe - area - inset - bottom,20px))

This PR solves that.

Fixes: #12281

@RobinMalfait RobinMalfait merged commit 761717c into master Oct 25, 2023
10 checks passed
@RobinMalfait RobinMalfait deleted the fix/issue-12281 branch October 25, 2023 13:20
RobinMalfait added a commit that referenced this pull request Oct 25, 2023
* sync package-lock.json

* prevent formatting inside `env()` when formatting `calc` function

* prevent formatting keywords in `calc`

* add dedicated normalization tests

* `calc()` in `env()` should be formatted

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grid-cols arbitrary value not working as expected
1 participant