Allow :global selector around @tailwind #12635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamwathan @thecrypticace Can someone take a look at this? I don't want to bug you, but just want to get it on your radar! Thanks! |
|
@RobinMalfait @KrisBraun Would it help this PR's chances if I rebased off of master again? |
|
Hey thanks for this! We decided to fix this more universally by just dramatically loosening the restrictions around nesting here: #13325 So this should work as expected when we tag the next release, likely today 💪 Really appreciate the PR! |
|
Awesome! I appreciate the work and you letting me know! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an updated version of #8418
The full explanation is there but essentially comes down to using CSS Modules with the default of a local scope. It helps prevent any custom css from conflicting in a large project while allowing the developer to use Tailwind for most components.