Migrate at-apply utilites with template migrations #14574
Conversation
philipp-spiess
requested review from
thecrypticace,
RobinMalfait and
adamwathan
philipp-spiess
force-pushed
the
feat/migrate-at-apply-candidates-with-candidate-migrations
branch
from
8b2c5ea
to
f306e98
Compare
packages/@tailwindcss-upgrade/src/codemods/migrate-at-apply.test.ts
Outdated
Show resolved
Hide resolved
| // If we have a valid designSystem and config setup, we can run all | ||
| // candidate migrations on each utility | ||
| if (designSystem && userConfig) { | ||
| params = params.map((param) => migrateCandidate(designSystem, userConfig, param)) | ||
| } |
There was a problem hiding this comment.
We should probably consider making a JS config file input required. This way we can simplify this decision here and don't have a case where @apply is migrated differently. Any thoughts on this @RobinMalfait?
There was a problem hiding this comment.
Yes, but I think a better way is to try to figure out where the config file lives (similar to how Tailwind CSS v3 just finds the config file if it's a known file name + extension in the root). If you have a custom file (aka, we can't resolve one) then the --config option should be required.
Another tricky thing, but will be more related to the stuff I'm working on with @thecrypticace (where we handle stylesheets as graphs to figure out which file imports what), is the fact that in theory you can have multiple roots with different settings. Which means that @apply in one file could require tw: prefixes, and the other file might not require prefixes.
There was a problem hiding this comment.
Yeah that makes sense! Adding a task
philipp-spiess
force-pushed
the
feat/migrate-at-apply-candidates-with-candidate-migrations
branch
from
d2bbddd
to
9f1419a
Compare
| 'src/input.css', | ||
| css` | ||
| .btn { | ||
| @apply tw:rounded-md! tw:px-2 tw:py-1 tw:bg-blue-500 tw:text-white; |
adamwathan
deleted the
feat/migrate-at-apply-candidates-with-candidate-migrations
branch
This PR extracts all candidate migrations from the existing template migrations and reuses these in the
@applyCSS migration. Seems like this JustWorks✨.