Make custom @at-root private API
#14618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an internal that cannot be constructed from CSS land which means that we can keep it private. This is a similar idea to the private `Context` node.
RobinMalfait
requested review from
philipp-spiess,
thecrypticace and
adamwathan
thecrypticace
approved these changes
Oct 7, 2024
RobinMalfait
commented
Oct 7, 2024
| @@ -22,7 +22,12 @@ export type Context = { | |||
| nodes: AstNode[] | |||
| } | |||
|
|
|||
| export type AstNode = Rule | Declaration | Comment | Context | |||
| export type AtRoot = { | |||
| kind: 'at-root' | |||
There was a problem hiding this comment.
If we ever need more like this, we could have a more generic marker node where you attach an additional sub-kind or w/e. I think this is the best solution for now though.
philipp-spiess
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the internal
@at-rootAPI private. Before this PR you could use@at-rootin your own CSS, which means that it was part of the public API. If you (accidentally) used it in variants, you could generate CSS that was completely broken.This now introduces a new private
AtRootnode (similar to the recently introducedContextnode) and can only be constructed within the framework.