Convert to/from v3 theme keys in configs and plugins #14642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
theme(‘boxShadow.*’) to --shadow-*
|
@adamwathan I think this covers everything. I know you talked about renaming |
philipp-spiess
approved these changes
Oct 11, 2024
@thecrypticace Let's wait until we actually rename that variable since that involves changes to the core |
thecrypticace
force-pushed
the
feat/v4-theme-fn-box-shadow
branch
from
0c997ba to
8473d46
Compare
thecrypticace
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few theme keys have changed in v4 relative to v3:
screens->--breakpoint-*colors->--color-*animation->--animate-*borderRadius->--radius-*boxShadow->--shadow-*When using the
theme()function we wouldn't pick up values from the CSS for some of these. Likewise, when loading a v3 config not all of these would be pushed back into the CSS theme and they should've been.This PR addresses both of these problems.