Always add layer(…) as the first param to @import
#15102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
feat/ensure-layers-come-first
branch
from
974fa56 to
ed60a68
Compare
RobinMalfait
force-pushed
the
feat/ensure-layers-come-first
branch
from
ed60a68 to
2e98679
Compare
thecrypticace
approved these changes
Nov 22, 2024
philipp-spiess
approved these changes
Nov 22, 2024
adamwathan
pushed a commit
that referenced
this pull request
Nov 22, 2024
This PR ensures that when we inject `layer(…)` into an `@import` that it always gets inserted as the first param. The `layer(…)` has to come first by spec. Input: ```css @import "./foo" supports(--foo); ``` Before: ```css @import "./foo" supports(--foo) layer(utilities); ``` After: ```css @import "./foo" layer(utilities) supports(--foo); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that when we inject
layer(…)into an@importthat it always gets inserted as the first param. Thelayer(…)has to come first by spec.Input:
Before:
After: