Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure .group and .peer are prefixed when using the prefix(…) option #15174

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Nov 25, 2024

This PR fixes an issue where the .group and .peer classes didn't get prefixed if you are using the prefix(…) option.

Before this change, tw:group-hover:flex, generated:

.tw\\:group-hover\\:flex {
  &:is(:where(.group):hover *) {
    @media (hover: hover) {
      display: flex;
    }
  }
}

But now it generates:

.tw\\:group-hover\\:flex {
  &:is(:where(.tw\\:group):hover *) {
    @media (hover: hover) {
      display: flex;
    }
  }
}

Or as a diff, it might be more clear:

  .tw\\:group-hover\\:flex {
-   &:is(:where(.group):hover *) {
+   &:is(:where(.tw\\:group):hover *) {
      @media (hover: hover) {
        display: flex;
      }
    }
  }

Fixes: #15172

@RobinMalfait RobinMalfait requested a review from a team as a code owner November 25, 2024 15:24
@adamwathan adamwathan merged commit 98359be into next Nov 25, 2024
1 check passed
@adamwathan adamwathan deleted the fix/issue-15172 branch November 25, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

group-hover is generated without respecting Tailwind CSS prefix option
2 participants