Upgrade: Migrate prefixed group and peer classes
#15208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwathan
approved these changes
Nov 27, 2024
philipp-spiess
force-pushed
the
fix/group-and-peer-classes-migration
branch
from
3a16360 to
d837068
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15193
This PR fixes an issue where
groupandpeerwould not have their prefixes migrated as part of the upgrade script. We do this by registeringgroupandpeeras utilities during the codemods. This way,parseCandidatewill find these classes to be valid Tailwind candidates and the prefix can be migrated just like any other utility.Test Plan
Tried it with the v3 upgrade playground in the repo and it worked fine:
I've also added tests to our prefix upgrade integration test and the prefix migration unit tests.