Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename --aspect-ratio-* theme key to --aspect-* #15365

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

reinink
Copy link
Member

@reinink reinink commented Dec 10, 2024

This PR renames the --aspect-ratio theme key to --aspect. This is to match what we've done with other theme keys where they match the utility names, like --ease and --leading.

  @theme {
-   --aspect-ratio-retro: 4 / 3;
+   --aspect-retro: 4 / 3;
  }

Additionally, I've also converted the existing aspect-video static utility to a theme value. This will allow people to override this utility in their own projects—something that's not possible with static utilities. This change feels appropriate since the video aspect ratio is subjective, unlike other static utilities like aspect-square.

@theme {
  --aspect-video: 4 / 3; /* N64 baby! */
}

@reinink reinink requested a review from a team as a code owner December 10, 2024 17:08
@reinink reinink changed the title Rename --aspect-ratio theme key to --aspect Rename --aspect-ratio-* theme key to --aspect-* Dec 10, 2024
@reinink reinink merged commit 2cbc915 into next Dec 10, 2024
1 check passed
@reinink reinink deleted the rename-aspect-ratio-theme-key-to-aspect branch December 10, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants