Add :host rule to @theme layer
#15975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugo-vrijswijk
force-pushed
the
add-host-theme-rule
branch
from
dd502e9 to
b4018f3
Compare
hugo-vrijswijk
force-pushed
the
add-host-theme-rule
branch
from
b4018f3 to
ff22dfa
Compare
Fixes tailwindlabs#15799 Adds a `:host` selector for the `@theme` layer. This is necessary for the `@theme` layer to work correctly in shadow DOM. Also updates the snapshots for the tests that were affected by this change.
hugo-vrijswijk
force-pushed
the
add-host-theme-rule
branch
from
ff22dfa to
21f70c3
Compare
|
This should also fix #14478 |
|
@hugo-vrijswijk Thanks a ton for this PR! I went ahead and did a round of testing on the known repro cases and added a test plan to your description. I also added a UI spec to ensure we have some validation. Note that because of |
thecrypticace
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15799
Resolves #14478
Part-of #15005
Adds a
:hostselector for the@themelayer. This is necessary for the@themelayer to work correctly in shadow DOM.Also updates the snapshots for the tests that were affected by this change (in a separate commit).
Test plan
Tested via the Vite playground:
Additionally made sure that
@propertydefaults also work across Firefox, Chrome, and Safari (the@propertydefinition from the root is pulled in) and added a UI spec.