Simplify animation tests and improve stability #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make sure that we tackle a few additional edge cases: - When the `name` is the same as a reserved keyword, then it will be used as a `name` as well. E.g.: 1s ease ease infinite; Will result in a name of `ease` as well. - We take care of trimming and multiple spaces. - We don't generate 8k tests anymore, which means that these specific tests only take a second instead of 10 seconds.
RobinMalfait
force-pushed
the
improve-animation-parsing
branch
from
6a6f11e
to
946e748
Compare
Codecov Report
@@ Coverage Diff @@
## master #4250 +/- ##
==========================================
- Coverage 71.17% 71.09% -0.08%
==========================================
Files 218 217 -1
Lines 4700 4701 +1
Branches 760 769 +9
==========================================
- Hits 3345 3342 -3
- Misses 1270 1273 +3
- Partials 85 86 +1
Continue to review full report at Codecov.
|
|
Thanks sir Robin 😘 |
|
|
adamwathan
pushed a commit
that referenced
this pull request
May 7, 2021
This will make sure that we tackle a few additional edge cases: - When the `name` is the same as a reserved keyword, then it will be used as a `name` as well. E.g.: 1s ease ease infinite; Will result in a name of `ease` as well. - We take care of trimming and multiple spaces. - We don't generate 8k tests anymore, which means that these specific tests only take a second instead of 10 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make sure that we tackle a few additional edge cases:
nameis the same as a reserved keyword, then it will beused as a
nameas well. E.g.: 1s ease ease infinite; Will result ina name of
easeas well.