[v2] Configure awaitWriteFinish
for chokidar
#5758
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures the
awaitWriteFinish
setting forchokidar.watch
. From thechokidar
documentation:The exact settings (
stabilityThreshold: 50, pollInterval: 10
) are based on those used bypostcss-cli
: https://github.com/postcss/postcss-cli/blob/master/index.js#L125-L128When looking into #5753 I observed that occasionally a file read will return an empty string on Windows, even when the file has contents. This can cause new classes to be missed. Configuring
awaitWriteFinish
helps to avoid this by delaying thechange
event until the file size has not change for 50ms. I was not able to reproduce the empty string issue withawaitWriteFinish
configured as per this PR.