Bump macOS GHA builds to macos-15, default to ARM64.
#389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StarWitch
changed the title
macos-15, default to ARM64.
Akaricchi
reviewed
Oct 14, 2024
| PYTHON_VERSION: '3.11.8' | ||
| PYTHON_VERSION: '3.11' |
There was a problem hiding this comment.
The images we use currently provide the latest 3.11.x dot-releases, which is something like 3.11.10.
Basically, by specifying 3.11.8, what would happen is that later revisions of 3.11.x would be uninstalled, at this older dot-release was being installed. It would uninstall 3.11.10 and install 3.11.8, which seemed really silly.
tl;dr: This speeds up the build process by about 10-15 seconds.
GHA macOS runners are now ARM64-default, and this required a few changes to make it work. We're almost at the release of the M4 processor, which means the Mac platform is now ~4 years into the move to ARM64, which means we need to start assuming this as the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHA macOS runners are now ARM64-default, and this required a few changes to make it work.
We're almost at the release of the M4 processor, which means the Mac platform is now ~4 years into the move to ARM64, which means we need to start assuming this as the default.
I also adjusted the standard CI test to represent aarch64 as the default.
Releases have also been tested: link