Add unit test for WebAssets class

[eyedol]

Follow up to #404.

Add missing unit test for WebAssets class

[takahirom]

Great!
Could we have a shared file list in WebAssets? I would like to make it easier to update the assets library.

val files = assetsPaths.entiries.flatMap{ it.values.map { it.substringAfterLast("/") } }

roborazzi/include-build/roborazzi-gradle-plugin/src/main/java/io/github/takahirom/roborazzi/WebAssets.kt

Line 27 in ffa6222

"css/materialize.min.css",

companion object {
  val assetsPaths = mapOf(
      materializeCss to listOf(
        "css/materialize.min.css",
        "js/materialize.min.js",
      ),
      materialIcons to listOf(
        "material-icons.css",
        "MaterialIcons-Regular.ttf",
      )
    )
}

[eyedol]

Yes we can do that. You want assetsPaths exposed publicly too?

[takahirom]

Can we use internal or @ VisibleForTesting? But I'm not sure if we can use @ VisibleForTesting in JVM. 👀

[eyedol]

Oh if it's for use with test, I prefer to keep it private then reconstruct it by hand in test since the values are hardcoded, it can be caught in unit test in case someone changes it in the SUT.

[eyedol]

I believe we can use @VisibleForTesting in jvm tests

[eyedol]

Sorry for the late response. I understand where you coming from though I think in this case it's fine to cause a duplicate as it could potentially catch an issue but yeah, I'll make it internal for reuse then.

[eyedol]

BTW, I changed the visibility to internal with 3e179ab

[eyedol]

@takahirom if all is good could you merge when you get the chance otherwise happy to fix anything I missed. Thanks

[takahirom]

Sorry for being late. What I wanted is to automate this using WebAssets.assetPathsMap so that we don't have to modify tests whenever files are changed.

    assertTrue(cssFile.exists())
    assertTrue(materializeCssFile.exists())
    assertTrue(materializeJsFile.exists())
    assertTrue(materialIconsCssFile.exists())
    assertTrue(materialIconsTtfFile.exists())

↓

val assetFiles = assetsPaths.entiries.flatMap{ it.values }.map { File(it) }

WebAssets.create().writeToRoborazziReportsDir(reportDir)

assetFiles.forEach { file->
  assertTrue(file.exists())
}

[eyedol]

Done with 04b0051

[takahirom]

Communicating with text can be challenging, but thank you for your patience in adding this!

[eyedol]

Communicating with text can be challenging, but thank you for your patience in adding this!

No problem. Thanks for the merge 🙏🏿