Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crop dropdown task run button #455

Merged

Conversation

eyedol
Copy link
Contributor

@eyedol eyedol commented Jul 29, 2024

Fixes #454

  • Remove anchoring of the JBBox harboring the toolbar to BorderLayout.WEST as it's causing the user to resize the window to reveal it fully.

Screenshot

Before After
Screen.Recording.2024-07-29.at.11.17.56.AM.mov
Screen.Recording.2024-07-29.at.11.20.24.AM.mov

@takahirom
Copy link
Owner

Thanks! Looks better! Ideally, I think it would be good to see weight 1 behavior for task names like :feature:verifyAnd... ♻️ (the 'run task' button should be wrap_content and the task name should have weight 1). However, this seems difficult to implement.

@takahirom takahirom merged commit b889e41 into takahirom:main Jul 30, 2024
6 checks passed
@eyedol eyedol deleted the eyedol/fixToNotHideDropdownWhenWindowIsSmall branch July 30, 2024 03:46
github-merge-queue bot pushed a commit to slackhq/circuit that referenced this pull request Aug 9, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[io.github.takahirom.roborazzi](https://github.com/takahirom/roborazzi)
| plugin | minor | `1.25.0` -> `1.26.0` |
|
[io.github.takahirom.roborazzi:roborazzi-junit-rule](https://github.com/takahirom/roborazzi)
| dependencies | minor | `1.25.0` -> `1.26.0` |
|
[io.github.takahirom.roborazzi:roborazzi-compose](https://github.com/takahirom/roborazzi)
| dependencies | minor | `1.25.0` -> `1.26.0` |
|
[io.github.takahirom.roborazzi:roborazzi](https://github.com/takahirom/roborazzi)
| dependencies | minor | `1.25.0` -> `1.26.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>takahirom/roborazzi (io.github.takahirom.roborazzi)</summary>

###
[`v1.26.0`](https://github.com/takahirom/roborazzi/releases/tag/1.26.0)

[Compare
Source](https://github.com/takahirom/roborazzi/compare/1.25.0...1.26.0)

##### Bugfix for iOS Compose Roborazzi

The iOS Compose Roborazzi has broken. The reason is that GitHub's
macos-latest has switched to an ARM-based CPU, and our tests have been
running X64Test. We couldn't check the status of iOS Roborazzi. We have
fixed this bug that prevented us from writing the test result JSON.
Special thanks to [@&#8203;eyedol](https://github.com/eyedol) for the
prompt fix!

##### What's Changed

- \[IntelliJ IDEA Plugin] Don't crop dropdown task run button by
[@&#8203;eyedol](https://github.com/eyedol) in
[takahirom/roborazzi#455
- \[Sample / Tests]Update dependency androidx.compose.runtime:runtime to
v1.6.8 by [@&#8203;renovate](https://github.com/renovate) in
[takahirom/roborazzi#343
- Set a classDiscriminator to avoid polymorphic serializer error by
[@&#8203;eyedol](https://github.com/eyedol) in
[takahirom/roborazzi#464

**Full Changelog**:
takahirom/roborazzi@1.25.0...1.26.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xOC4xNyIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE3IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issue where task run button is cropped in IDE plugin
2 participants