Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] #700110 - DS Internationalization #273

Merged
merged 7 commits into from
Aug 29, 2024
Merged

[Feature] #700110 - DS Internationalization #273

merged 7 commits into from
Aug 29, 2024

Conversation

adrianoct42
Copy link
Collaborator

This PR aims to make a lot (if not all) texts used in BlipDS to be dynamically used, based on the user language.

@adrianoct42 adrianoct42 self-assigned this Aug 26, 2024
mpamaro
mpamaro requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@mpamaro mpamaro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes are great, but I've left some comments in Blip Desk App PR that will require some adjustments here! 🙂

@mpamaro mpamaro merged commit 615879e into develop Aug 29, 2024
1 check passed
@mpamaro mpamaro deleted the feature/700110-ds-internationalization branch August 29, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpamaro mpamaro mpamaro approved these changes

@githubdoandre githubdoandre Awaiting requested review from githubdoandre

@leonardogbr leonardogbr Awaiting requested review from leonardogbr

Assignees

@adrianoct42 adrianoct42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianoct42 @mpamaro