Feature/sales force lead #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisbaggins
commented
Oct 14, 2021
louisbaggins
commented
- Add: Crm register and get lead base class;
- Add :SalesForce integration;
- Add: Register lead on salesforce;
- Add: Register lead on salesforce tests;
- Add: Get lead on SalesForce;
- Add: Get lead on salesforce tests;
- Add: Advanced Config extension;
- Add: Advanced ConfigExtension tests;
Refac: unnecessary casting in configuration extension test
Add: Context for other crm's strategys
…the reorganize CRM integration Add: CRM Enum with list of integrated enums Add: Register lead action tests
Add: New configuration extension method with generic type return
Add: Add new configuration test to typed method values
Refac: Remove client and strategie from create lead action folder to facilitate addition of new related actions
Add: Get lead action Refac: Add action type analysis on CrmContext
Refac: Change Crm settings validation message Add: Get lead action tests
EricJangola
reviewed
Oct 15, 2021
src/Take.Blip.Client.UnitTests/Extensions/Configurations/ConfigurationExtensionTests.cs
Show resolved
Hide resolved
src/Take.Blip.Client.UnitTests/Extensions/Configurations/ConfigurationExtensionTests.cs
Outdated
Show resolved
Hide resolved
Refac: New base interface ICrmClient, SalesForceClient now will inherit from CrmClient to facilitate the add on of new crm's Refac: Change action type enum name to CrmActionType Refac: Remove empty spaces
Refac: Action type name
Add: Fail on getting lead test Refac: Add treatment on salesforce client to non successful responses Refac: Add salesforce base url on ConventionsConfiguration to allow use as a cd variable
EricJangola
reviewed
Nov 8, 2021
src/Take.Blip.Builder/Utils/SalesForce/Models/SalesForceRoutes.cs
Outdated
Show resolved
Hide resolved
EricJangola
approved these changes
Nov 8, 2021
caiopsouza
suggested changes
Nov 12, 2021
There was a problem hiding this comment.
I left a lot of suggestions, only real issue I found is using the HttpClient class directly which can have serious performance impact.
Take a look at https://docs.microsoft.com/pt-br/dotnet/architecture/microservices/implement-resilient-applications/use-httpclientfactory-to-implement-resilient-http-requests for more info.
src/Take.Blip.Client/Extensions/AdvancedConfig/ConfigurationExtension.cs
Outdated
Show resolved
Hide resolved
src/Take.Blip.Client/Extensions/AdvancedConfig/ConfigurationExtension.cs
Show resolved
Hide resolved
Refac: Remove unused libs
…s always realized on previous function
EricJangola
approved these changes
Feb 1, 2022
caiopsouza
approved these changes
Feb 1, 2022
jujucasseb
reviewed
May 6, 2022
| /// Bool that indicates if lead was created | ||
| /// </summary> | ||
| [JsonProperty("success")] | ||
| public bool Succes { get; set; } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.