Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify previous stateid and stateid #174

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

DanielFonsecaTake
Copy link
Contributor

@DanielFonsecaTake DanielFonsecaTake commented Feb 16, 2023

Changed the way of store previous-stateId and stateId context variables to store its values in a single variable.

StateManager:

  • Method GetStateIdAsync now extract the state id from the stateid context variable and treats both the new and old format;
  • Method GetPreviousStateIdAsync now tries to extract the previous state id from the stateid context variable, if it is not present, it searches the old previousstateid context varible for a value and returns it;
  • Method SetStateIdAsync now receives previousStateId as parameter to set it along with the stateid;
  • Method SetPreviousStateIdAsync was deleted as it became useless;

@DanielFonsecaTake DanielFonsecaTake changed the title Feature/402227 unify previous state Unify previous stateid and stateid Feb 17, 2023
}

public Task SetStateIdAsync(IContext context, string stateId, CancellationToken cancellationToken)
public Task SetStateIdAsync(IContext context, string stateId, string previousStateId, CancellationToken cancellationToken)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants