Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Feature/new blip input #38

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat: Feature/new blip input #38

wants to merge 8 commits into from

Conversation

brennerp
Copy link
Contributor

No description provided.

brennerp added 4 commits April 10, 2019 14:16
@brennerp
refactor(BLiP Input): Refactor BLiP Input and _input.scss
b28b45c 
BREAKING CHANGE: The old bp-input is now bp-input-field, it has to be replaced in BLiP Input,
Checkbox, Radio and others.
@brennerp
fix(BLiP Input): Small fix
7069e44
@brennerp
fix(BLiP Input): Fix hmtl
da44b98
@brennerp
fix(BLiP Input): Changed organization and CSS of BLiP Input
36e6034 
BREAKING CHANGE: Names and structure of BLiP Input were changed.
@codecov
Copy link

codecov bot commented Apr 16, 2019 •
edited
Loading

Codecov Report

Merging #38 into master will decrease coverage by 0.12%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   62.27%   62.15%   -0.13%     
==========================================
  Files          18       18              
  Lines         904      893      -11     
  Branches      193      192       -1     
==========================================
- Hits          563      555       -8     
+ Misses        341      338       -3
Impacted Files Coverage Δ
src/components/blipTags/index.js 50.34% <100%> (+0.34%) ⬆️
src/components/blipSelect/index.js 54.69% <66.66%> (+0.97%) ⬆️
src/components/blipInput/index.js 60% <73.33%> (-0.63%) ⬇️
src/components/blipModal/index.js 51.51% <0%> (-12.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caaa158...b86277e. Read the comment docs.

brennerp added 4 commits June 24, 2019 11:35
@brennerp
feat(Refactory of BLiP Tags, Input and Select): Refactory
9af2d99 
Changed class names and CSS for input, select and tags

BREAKING CHANGE: Class names of elements
@brennerp
Merged master and removed tachyons classes and replaced them with a t…
0763079 
…oolkit one
@brennerp
Fixed tests
f5b8907
@brennerp
feat(BLiP Input, Tags and Select): Fixed tests and class names and or…
b86277e 
…ganization

BREAKING CHANGE: Class names, CSS and input structure
@samwx samwx closed this Jun 25, 2019
@samwx samwx reopened this Jun 25, 2019
@samwx samwx added the should-wait This PR/Issue shoul wait to be analysed/merged/resolved label Jul 12, 2019
@EricJangola EricJangola requested review from samwx and removed request for samwx July 1, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
should-wait This PR/Issue shoul wait to be analysed/merged/resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brennerp @samwx