Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ensures lock doesn't affect the message removal #42

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

cezar-tech
Copy link
Contributor

@cezar-tech cezar-tech commented Oct 2, 2023

Ensures via tests that even if you ack or nack a message with removal set true that it doesn't bug out and stays in the queue somehow.

Also adds checking with count to be more precise

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #42 (07f88a9) into main (943186f) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files          26       26           
  Lines        3696     3696           
=======================================
  Hits         3035     3035           
  Misses        519      519           
  Partials      142      142           

Signed-off-by: Cezar Augusto Nascimento e Silva <cezar.augusto@blip.ai>
Copy link
Member

@lucasoares lucasoares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cezar-tech cezar-tech changed the title test: ensures lock doesn't affect message removal test: ensures lock doesn't affect the message removal Oct 4, 2023
@cezar-tech cezar-tech merged commit f15566d into main Oct 4, 2023
9 checks passed
@cezar-tech cezar-tech deleted the test-lock-and-remove branch October 4, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants