Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If no cache is set, it defaults to CACHE_SIZE_NO_LIMIT which will consume all available (heap) memory #17

Closed
Ramon-Leeuwe opened this issue Jan 1, 2023 · 2 comments
Closed

If no cache is set, it defaults to CACHE_SIZE_NO_LIMIT which will consume all available (heap) memory #17

Ramon-Leeuwe opened this issue Jan 1, 2023 · 2 comments

Comments

@Ramon-Leeuwe
Copy link

If no cache is set, it defaults to CACHE_SIZE_NO_LIMIT which will consume all available (heap) memory.
It might be better to set the default to a lower limit and add a note in the doc's to explain how to increase the cache if needed.
@takkaO takkaO added the progress: fixing Fixing code now label Jan 4, 2023
@takkaO
Copy link
Owner

takkaO commented Jan 15, 2023

Hi @Ramon-Leeuwe
Thank you for using this library 😊 and sorry for late reply.

I think it is a good idea.
I will be imported into the next version.

@Ramon-Leeuwe
Copy link
Author

Thanks for fixing this issue. 👍
I really like your project, but struggled a bit with memory management (not enough memory).
That's why I raised this issue.

takkaO added a commit that referenced this issue Feb 2, 2023
@takkaO
[Fix] Fixed a bug where right-align offsets were not calculated corre…
1633fb2 
…ctly.

- Fixed a bug where right-align offsets were not calculated correctly.
- Default cache size changed from unlimited to minimum (#17).
- Fixed a bug that caused a buffer overflow in the drawChar function.
- Fixed a bug in drawChar function where the align argument was ignored.
- Increment version number.
@takkaO takkaO removed the progress: fixing Fixing code now label Feb 2, 2023
@takkaO takkaO mentioned this issue Feb 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@takkaO @Ramon-Leeuwe