Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

These changes prevent processor crashes when unloadFont called #16

Merged
merged 3 commits into from
Feb 2, 2023
Merged

These changes prevent processor crashes when unloadFont called #16

merged 3 commits into from
Feb 2, 2023

Conversation

Bodmer
Copy link
Contributor

@Bodmer Bodmer commented Dec 23, 2022

No description provided.

takkaO and others added 3 commits November 24, 2022 22:43
Uses the "g_NeedInitialize" flag which is set false when a font is loaded, and true when unloaded.
@Bodmer Bodmer changed the title These changes preven processor crashes These changes prevent processor crashes when unloadFont called Dec 23, 2022
@MikeyMoMo
Copy link

I have put in this update and am now running my code with it. It seems stable so far. I have always done a font unload before any font load with base tft_eSPI library code. That caused the known crash with the OFR code. Now, all is well. It includes all of the changes mentioned in #16.

Thanks for the fix. We are getting closer to having a solid library. Just the font lowering problem remains for me. It was reported as a font sizing problem but seems to be that there is blank space above the font. Sample program demonstrating this has been submitted to takka0.

An aside. Moving from multiple font size bitmapped files in my code to the OFR version has reduced the code size from 61% of huge partition to 44% and, of course, allowed me to delete 10s of thousands of lines of bitmapped fonts. A font size 190 makes a LOT of data!! Now, just the two TTF bitmaps and ability to print in multiple sizes. It is so GREAT!!!
Mike

@takkaO takkaO changed the base branch from master to develop February 2, 2023 12:16
@takkaO takkaO merged commit 17395a3 into takkaO:develop Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants