Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.0.7] Modify an argument of Trainer::train() #4

Closed
taku-y opened this issue Mar 20, 2024 · 0 comments
Closed

[v0.0.7] Modify an argument of Trainer::train() #4

taku-y opened this issue Mar 20, 2024 · 0 comments

Comments

@taku-y
Copy link
Owner

taku-y commented Mar 20, 2024

In the current implementation, one of the input arguments Recorder is a concrete type. It should be replaced with a trait object implementing Recorder. This change allows to change the concrete type of Recorder at runtime.
@taku-y taku-y changed the title [v0.0.7] Modify arguments of Trainer::train() [v0.0.7] Modify an argument of Trainer::train() Mar 20, 2024
taku-y added a commit that referenced this issue Mar 20, 2024
@taku-y
Replace input argument with trait object (#4)
547fc91
@taku-y taku-y closed this as completed Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taku-y