Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the test case to prevent it from not being tested. #459

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

yanghy233
Copy link
Contributor

When I tested project4B (make project4B), TestCommitMissingPrewrite was not executed, but in fact, it is a very good test case to find the bug.

@yanghy233 yanghy233 changed the title Correct the test cases to prevent the TestCommitMissingPrewrite4B cas… Correct the test cases to prevent them from not being tested. Oct 11, 2024
@yanghy233 yanghy233 changed the title Correct the test cases to prevent them from not being tested. Correct the test case to prevent it from not being tested. Oct 11, 2024
Copy link
Collaborator

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Connor1996 Connor1996 merged commit b3bb260 into talent-plan:course Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants