fix: detect selfdestruct in internal calls (crytic#2232)

* fix: detect selfdestruct in internal calls

* update snapshot

slither/detectors/functions/suicidal.py

@@ -59,7 +59,7 @@ def detect_suicidal_func(func: FunctionContract) -> bool:
         if func.visibility not in ["public", "external"]:
             return False
 
-        calls = [c.name for c in func.internal_calls]
+        calls = [c.name for c in func.all_internal_calls()]
         if not ("suicide(address)" in calls or "selfdestruct(address)" in calls):
             return False
 

tests/e2e/detectors/snapshots/detectors__detector_Suicidal_0_7_6_suicidal_sol__0.txt

@@ -1,2 +1,4 @@
+C.i_am_a_backdoor2(address) (tests/e2e/detectors/test_data/suicidal/0.7.6/suicidal.sol#8-10) allows anyone to destruct the contract
+
 C.i_am_a_backdoor() (tests/e2e/detectors/test_data/suicidal/0.7.6/suicidal.sol#4-6) allows anyone to destruct the contract
 

tests/e2e/detectors/test_data/suicidal/0.7.6/suicidal.sol

@@ -5,4 +5,12 @@ contract C{
         selfdestruct(msg.sender);
     }
 
+    function i_am_a_backdoor2(address payable to) public{
+        internal_selfdestruct(to);
+    }
+
+    function internal_selfdestruct(address payable to) internal {
+        selfdestruct(to);
+    }
+
 }