New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Parameterize creds destination file #152

Closed

cphoward wants to merge 1 commit into master from cph/creds-dest-file

Contributor

cphoward commented Jun 21, 2024 •

edited

Loading

Summary

Custom Checklist Items

Standard Checklist

My comments/docstrings/type hints are clear

I've written new tests or this change does not need them

I've tested this manually

The architecture diagrams have been updated, if need be

Any external changes/dependencies are linked and described

I've included any special rollback strategies above

Any relevant metrics/monitors/SLOs have been added or modified

I've notified all relevant stakeholders of the change

I've updated .github/CODEOWNERS, if relevant


          feat: Make creds destination file parameterized

2a60424

cphoward requested review from TheKevJames and a team as code owners

June 21, 2024 16:37

cphoward requested review from shaundialpad and olidp and removed request for a team

June 21, 2024 16:37

TheKevJames reviewed

View reviewed changes

Member

TheKevJames left a comment

What's the goal of letting this be parametrizable?

cphoward closed this

TheKevJames deleted the cph/creds-dest-file branch

June 24, 2024 17:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

TheKevJames TheKevJames left review comments

shaundialpad Awaiting requested review from shaundialpad shaundialpad is a code owner automatically assigned from talkiq/engineering

olidp Awaiting requested review from olidp olidp is a code owner automatically assigned from talkiq/engineering

Labels

None yet