Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update CODEOWNERS with cphoward #160

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

cphoward
Copy link
Contributor

Summary

Custom Checklist Items

Standard Checklist

  • My comments/docstrings/type hints are clear
  • I've written new tests or this change does not need them
  • I've tested this manually
  • The architecture diagrams have been updated, if need be
  • Any external changes/dependencies are linked and described
  • I've included any special rollback strategies above
  • Any relevant metrics/monitors/SLOs have been added or modified
  • I've notified all relevant stakeholders of the change
  • I've updated .github/CODEOWNERS, if relevant

@cphoward cphoward requested review from TheKevJames and a team as code owners August 27, 2024 21:55
@cphoward cphoward requested review from santiagofdialpad and mauroparis and removed request for a team August 27, 2024 21:55
@cphoward cphoward enabled auto-merge (squash) August 28, 2024 13:52
Comment on lines +3 to +4
pyproject.toml @TheKevJames @cphoward
poetry.lock @TheKevJames @cphoward
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove these two lines? They're legacy, I had meant to remove 'em from all repos but must have missed a spot.

Copy link
Contributor

@eddiedialpad eddiedialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ approved: codeowners += Casey 💖

@cphoward cphoward merged commit 1911432 into master Aug 28, 2024
12 checks passed
@cphoward cphoward deleted the cph/CODEOWNERS-update branch August 28, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants