Reorder Library, t_slv_arr #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrel_switcher has different behaviour to that of simulink but I cannot for the life of me make heads or tails of what to do about that so, waiting for complaints with actual statements of expected behaviour in order to fix
*^ REODER/barrel_switcher which was correct but didn't have similar behaviour before sync_out
working in vivado with dbl_buffer enabled, there asides not working...
|
@radonnachie shall I proceed with this PR? |
May just want to highlight this somewhere and draw attention to it so I can get feedback on how to fix it. |
|
@talonmyburgh |
|
Reorder block failing tests - @radonnachie requires assistance on expected DSP operation in order to fix. Merging in the interim. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the BarrelSwitcher, SquareTransposer, DoubleBuffer and Reorder blocks from the Reorder DSP blockset.
The BarrelSwitcher and SquareTransposer match simulink and have passing testbenches.
The reorder block is still WIP. It operates correctly with the double-buffer under Vivado simulation, but there asides does not perform well. I reckon I need to work with someone who knows what to expect from the block in order to make quick progress forward. It's mostly there, just dotting the 'i's and crossing the 't's.