Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce Order struct to consistent order of result. #31

Merged
merged 12 commits into from
Mar 25, 2021

Conversation

tamada
Copy link
Owner

@tamada tamada commented Mar 22, 2021

#30

The cause of this bug is to open too many files.
In the current implementation, wildcat opens files at once and collects all files, then counts collected entries in each goroutine.
Therefore, too many entries may cause the hang by the limit of the file handers.

To fix the bug, I will update as follows.

  • introduce Order struct for consistent orders in the results.
  • no collect entries, and count each entry in each goroutine.
  • collect Result for printing results.

@tamada tamada added bug Something isn't working enhancement New feature or request labels Mar 22, 2021
@tamada tamada added this to the v1.1.1 milestone Mar 22, 2021
@tamada tamada self-assigned this Mar 22, 2021
@tamada tamada merged commit 10ca18e into main Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant