Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to an another JSON schema validator #136

Closed
tamasfe opened this issue Jul 10, 2021 · 1 comment · Fixed by #211
Closed

Switch to an another JSON schema validator #136

tamasfe opened this issue Jul 10, 2021 · 1 comment · Fixed by #211
Labels
enhancement schema JSON-schema related issues

Comments

@tamasfe
Copy link
Owner

tamasfe commented Jul 10, 2021

Ditching verify, and using jsonschema instead would probably bring several improvements.

The original idea of using verify was to avoid looking up the positions invalid sections after validation, however it is very slow, not extensible, and I don't have time to maintain it.

Using an actually maintained validator would be an improvement already, especially if it supports resolving references. On top of that jsonschema can be up to 10000x faster (yes, indeed), and even with the additional lookups validation should be much faster.

@tamasfe
Copy link
Owner Author

tamasfe commented Jan 8, 2022

For anyone wondering why there is no progress on this, this is blocked on Stranger6667/jsonschema#246. Taplo currently works in WASM environments which is a feature that we'll likely keep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement schema JSON-schema related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant