-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Massive Refactor and Rewrite #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphar
added a commit
to syphar/nvim-lspconfig
that referenced
this pull request
Mar 27, 2022
taplo was refactored and taplo-lsp was merge into taplo-cli. tamasfe/taplo#211
syphar
added a commit
to syphar/nvim-lspconfig
that referenced
this pull request
Mar 27, 2022
taplo was refactored and taplo-lsp was merge into taplo-cli. see also tamasfe/taplo#211
syphar
added a commit
to syphar/nvim-lspconfig
that referenced
this pull request
Mar 27, 2022
taplo was refactored and taplo-lsp was merge into taplo-cli. see also tamasfe/taplo#211
syphar
added a commit
to syphar/nvim-lspconfig
that referenced
this pull request
Apr 5, 2022
taplo was refactored and taplo-lsp was merge into taplo-cli. see also tamasfe/taplo#211
tamasfe
pushed a commit
that referenced
this pull request
Oct 7, 2022
This env's use was removed in #211, so the build script is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the reasons why I always kept postponing patches and updates in this project was the fact that it was pretty hard to maintain. When I originally wrote most of it, I barely had time and just wanted to get features out ASAP.
The Even Better TOML has recently passed the 100K installs mark, I felt that some cleanup and care was long overdue.
This PR is pretty much a rewrite and/or a major refactor of Taplo with the only exception of the parser, which I would love to rewrite as well but I'm already pushing my time-limits.
Features
taplo-common
, so the CLI and the LSP are no longer out of sync.Breaking Changes
Probably a lot, but here are a few notable ones:
Merging this PR should:
schema.enabled
key is omitted #176$ref
s are used that are not supported #120