Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken on latest nightly #628

Closed
scrabsha opened this issue Jul 6, 2024 · 8 comments · Fixed by #598
Closed

Build broken on latest nightly #628

scrabsha opened this issue Jul 6, 2024 · 8 comments · Fixed by #598

Comments

@scrabsha
Copy link

scrabsha commented Jul 6, 2024

I hit the following error when installing taplo:

$ cargo install taplo-cli --locked
error[E0635]: unknown feature `stdsimd`
  --> /home/scrabsha/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.7.6/src/lib.rs:33:42
   |
33 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))]
   |                                          ^^^^^^^

Maybe this can be fixed by bumping one of the dependencies?

I'm using the following nightly:

$ rustc --version
rustc 1.81.0-nightly (524d806c6 2024-07-05)
@panekj
Copy link
Collaborator

panekj commented Jul 6, 2024

Is there any reason you can't use stable rust?

@scrabsha
Copy link
Author

scrabsha commented Jul 6, 2024

None, nightly is just my default toolchain

I'm fine with you supporting only stable Rust (it's even better, actually!), but this should be documented.

@scrabsha
Copy link
Author

scrabsha commented Jul 6, 2024

Can confirm it builds on stable. I'm going to update the taplo docs then :)

@panekj
Copy link
Collaborator

panekj commented Jul 6, 2024

but this should be documented.

I don't think that us not supporting constantly changing highly experimental compiler versions is something we should pertain ourselves in documentation. After all one nightly might work, other might don't and the status changes constantly.

@scrabsha
Copy link
Author

scrabsha commented Jul 6, 2024

fine. feel free to close this issue if you think the doc are good as is.

@panekj
Copy link
Collaborator

panekj commented Jul 6, 2024

I'll leave it open for now in case any other maintainer becomes active again and thinks otherwise

@panekj
Copy link
Collaborator

panekj commented Jul 6, 2024

Also a note about dep

Maybe this can be fixed by bumping one of the dependencies?

Unfortunately it's ahash which brings circular dependency issues and we already had few times problems dealing with it, I'm currently unsure if that dependency leaf can be brought up on par with the other one (we have 0.7 and 0.8 ahash in lockfile) but I'll try looking into it at some point.

panekj added a commit that referenced this issue Jul 6, 2024
panekj added a commit that referenced this issue Jul 6, 2024
@awnion
Copy link

awnion commented Jul 28, 2024

Works without --locked so maybe bumping .lock would be a good idea

panekj added a commit that referenced this issue Jul 28, 2024
panekj added a commit that referenced this issue Aug 6, 2024
panekj added a commit that referenced this issue Aug 16, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants