-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented EXP, INT, and MONTH functions #13
base: master
Are you sure you want to change the base?
Conversation
src/excel/excel_functions/month.rb
Outdated
def month(a) | ||
return 0 if a.nil? | ||
return :error unless a.is_a? Numeric | ||
a ||= 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this line needed? Given you have already tested for nil in line 8?
Cool. Looks pretty close. Thanks. If you don't have time to look at my comments, then I'll give them a go at some point in the next few weeks and then merge. |
Great points! I'll implement your suggestions. Might take a few days. We move so fast here I just get it working first. Then refactor when time is available. But I'll make these changes as soon as possible. Thanks! Chris ----- Original Message ----- From: "Tom Counsell" notifications@github.com Cool. Looks pretty close. Thanks. If you don't have time to look at my comments, then I'll give them a go at some point in the next few weeks and then merge. — |
…xcel_to_code into exp_int_month_functions
This reverts commit d46088e. Conflicts: src/compile/ruby/map_formulae_to_ruby.rb src/excel/excel_functions.rb
Wrote test and implementation for the following Excel functions
EXP
INT
MONTH