-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disney+ not responding to ultrawidify #84
Comments
It's like I wrote the template for nothing.
Troubleshooting (since disney+ is geoblocked for me)Open console while on Disney+. Press F12, you should get something like this: Paste the following and press enter, what do you get (please respond with the screenshot)? var v = document.getElementsByTagName('video')[0];
var e = v;
console.log("————————————————————————————————————————[ element sizes ]————————————————————————————————————————");
console.log(`window size: ${window.innerWidth} x ${window.innerHeight}`)
while (e) {
console.log( `size (offset): ${e.offsetWidth} x ${e.offsetHeight} | size (client): ${e.clientWidth} x ${e.clientHeight}`, "element:", e,);
e = e.parentNode;
}
console.log("————————————————————————————————————————[ end element sizes ]————————————————————————————————————————");
function equalish(a,b, tolerance) {
return a > b - tolerance && a < b + tolerance;
}
function findPlayer() {
let video = document.getElementsByTagName("video")[0];
let element = video.parentNode;
const videoWidth = video.offsetWidth, videoHeight = video.offsetHeight;
const elementQ = [];
let scorePenalty = 0;
let score;
if(! element ){
if(element) {
const ths = this;
}
element = undefined;
dimensions = undefined;
return;
}
// try to find element the old fashioned way
while (element){
// odstranimo čudne elemente, ti bi pokvarili zadeve
// remove weird elements, those would break our stuff
if ( element.offsetWidth == 0 || element.offsetHeight == 0){
element = element.parentNode;
continue;
}
// element je player, če je ena stranica enako velika kot video, druga pa večja ali enaka.
// za enakost dovolimo mala odstopanja
// element is player, if one of the sides is as long as the video and the other bigger (or same)
// we allow for tiny variations when checking for equality
if ( (element.offsetWidth >= videoWidth && equalish(element.offsetHeight, videoHeight, 2))
|| (element.offsetHeight >= videoHeight && equalish(element.offsetWidth, videoHeight, 2))) {
// todo — in case the match is only equalish and not exact, take difference into account when
// calculating score
score = 100;
score -= scorePenalty++; // prefer elements closer to <video>
elementQ.push({
element: element,
score: score,
});
}
element = element.parentNode;
}
if (elementQ.length) {
// return element with biggest score
const playerElement = elementQ.sort( (a,b) => b.score - a.score)[0].element;
console.log("elementQ:", elementQ);
console.log(`best match | offset: ${playerElement.offsetWidth} x ${playerElement.offsetHeight} | client: ${playerElement.clientWidth} x ${playerElement.clientHeight} | element:`, playerElement);
} else {
console.log("NO PLAYER ELEMENT FOUND!");
}
}
console.log("———————————————————————————————[ will find player element ]———————————————————————————————");
findPlayer();
console.log("———————————————————————————————[ f i n i s h e d ]———————————————————————————————"); You should be seeing something like this (if you combined both of the following screenshots together). This example is from youtube. |
I think I had not refreshed the page after I clicked enable for the plugin on that page, it seems to be working for me, @MazelTovCocktail might want to try that. |
@EvilPaul2012 was ultrawidify disabled on disney+ by default? |
I think it might have been or nothing selected. I was trying a lot of settings and forget what it was originally, sorry. |
Ok then. Does the extension continue to work if you close the tab and reopen it again, or if you close or repoen the browser? Or do you have to enable the extension from the plugin every time? I ask because there's two options:
¹ "Disney+ not working" was reported by someone via a different channel already. This version (4.4.2) was supposed to have a fix for this problem, buut ... well, judging by this issue, it wasn't very effective. |
Sorry for the delay. I tried again and on the same movie and I could not get it to work again. Pressing shortcut keys didnt do anything either. |
Try opening the popup, go to site settings (or extension settings) and try
doing either of these things and DO NOT RELOAD THE PAGE AT ANY POINT —
that's important:
* Under 'Enable extension [for <site>]', click 'Disable' and then 'Enable'
(or default) again.
* Under 'Autodetection settings [for <site>]', click 'Disable' and then
'Enable' (or default) again.
For the time being, it doesn't matter which of these four options you
follow (as long as you click 'disable' and then 'enable').
After you do that, wait a few seconds. If autodetection is enabled (it
should be by default), did extension crop the video (assuming the video can
be cropped)? If not, can you crop the video using popup buttons or keyboard
shortcuts?
:
:
If the answer to both of these is no — refresh the page with **Ctrl + F5,**
open the popup, go to 'Advanced settings' and uncheck the 'detect
automatically' checkbox. Then check it again. (Someone told me that this
worked for them) Wait a few seconds. Did autodetection kick in? If not, can
you crop the video using popup buttons or keyboard shortcuts?
|
I've just pushed an update that might be able to solve this issue. It's out for Firefox, it'll take up to a week for Chrome. Once you get the update for v4.4.3, please tell me whether it fixes the issue or not. |
Tried your suggestions with the new version and couldn't get it to work. I even uninstalled and reinstalled the plugin. I can't seem to change the size with keyboard shortcuts either. They do work on youtube. Disney+ does have shortcuts for A and D already for fast forward and rewind. I wish I knew what I did to get it to work before. I'll try again tomorrow. |
Okay sorry for delays, but this extension has been having a bit of problems lately (and I was a bit busy with IRL stuff). If you're using Firefox, go to disney plus, open the popup and click Advanced settings tab, uncheck Detect automatically checkbox under Player Detection Settings and enter Pic for reference, because my instructions are a bit crap: |
No worries, I understand it is a side project for you. Sorry but no luck for me :( I tried what you said a few times, I tried messing with some settings to see if that would work. I also removed and reinstalled the plugin, did the instructions, and then tested again. I do run FF beta but when I first test it seemed like the v74 release and there was an update when I checked which was the v75b. |
Hi, for me it's working on Chrome (Version 80.0.3987.149, Plugin Version 4.4.7). The only thing is, that videos are directly set to fit width as soon as i go full screen and when i press the shortcut for "fit width" it zooms in. Maybe that helps? |
@EvilPaul2012 FYI, Ultrawidify works with Disney+ out of the box (didn't need the workaround detailed above) for me on Firefox Dev 76.0b1. |
Hi, using Win10 / Firefox 84.0.2 / Ultrawidify 4.5.1 it doesn't work for me on Disney+. |
@ocinon Can I ask you a favour?
You need to use this extension to save the webpage because this extension includes all dynamically rendered page elements and CSS (and saving the page with ctrl+s doesn't). Thanks in advance. |
Sure. See the file attached. There were 2 objects the extension couldn't save, but the html page still seems to load fine. |
Thanks. Try this:
Does that fix the issue? |
That fixed the issue! Thanks so much |
Looks like they changed the CSS to:
Parent 1 |
Hi, sorry for long time no reply & thanks for providing some info. Just a quick question, though. With parent set to |
Checkbox needs to be checked Or actually, just setting the video** to be "btm-media-client-element" manually works. Sadly it looks like the captions are baked into the player |
Ok thanks, I'll try to have an update out soon. |
Had this problem recently, this setting worked for me (Samsung 49" 1440p) |
Closing becasue this problem appears to have been fixed and unfixed a few times, latest iteration was #211 |
still not working |
the addon won't crop in on disney+ content and doesnt seem to respond in any way.
The text was updated successfully, but these errors were encountered: