-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS 2019 and VS 2022 compatible version #14
Open
denisabt
wants to merge
26
commits into
tanathos:master
Choose a base branch
from
denisabt:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e tested. 2019 running.
Vs2022 from master
* Add Merlin Resources to Shared Project * Move stuff up to AssistantBase - WIP * Add Merlin Resources to Project * Alpha Merlin Version hard-wired. Canvas size not correct - wip * Code Change done - untested yet - WIP * Add Merlin - Timing issue with Merlin, to be debugged. * Add Merlin timing debug logs * Try to fix merlin anims, and assistant switch * Dispose idle timers when switching Agents, and debug some Merlin animations * Fix Assistant switching so that it works :) * Debug Merlin Animations - skip empty row/column frame definitions. * Debug Merlin Animation timing issue - Wip * Code Cleanup * Code cleanup * Fix invalid Merlin Idle Animation reference Co-authored-by: Abt Denis (CH-IKB) <Denis.Abt@swisslife.ch>
* Add Genius Menu Item - WIP ! * Genius shows up - but misbehaves (animation issues) - WIP * Genius works, except for Sendmail animation (which seems to require branching or similar to work) * Add comment about failing genius animation * Add Genius and show it again on startup if selected on last run. Layering and branching to be added. Co-authored-by: Abt Denis (CH-IKB) <Denis.Abt@swisslife.ch>
* Initial POC version not rendering yet. WIP ! * WIP - not working - add overlay canvasses * add overlay support for genius, debug to be done , fix merlin launch issue * Fix Overlay Layer visibility issue * Clean up code * Code cleanup * Code fix Co-authored-by: Abt Denis (CH-IKB) <Denis.Abt@swisslife.ch>
* Refactor genius inital layer version, (better) object model. * WIP Visibily Support addon - * Enable proper per frame layer visibility support for multi layer anims - initial version works!! * Minor code cleanup * Manifest update for Genius and Merlin
* Test coverage and code consolidation. Test WELL with both visual studio versions! WIP * separate classes and structs -wip * code cleanup * add AssistantBase tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, could you check if this works for you for both 2019 and 2022 versions ? I've tested it on both, so hopefully that's a good candidate for master :-)