Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report tile utilization with DVFS info #29

Merged
merged 25 commits into from
Nov 25, 2024
Merged

Report tile utilization with DVFS info #29

merged 25 commits into from
Nov 25, 2024

Conversation

tancheng
Copy link
Owner

No description provided.

@tancheng tancheng requested review from cwz920716 and MeowMJ November 21, 2024 01:30
@tancheng tancheng self-assigned this Nov 21, 2024
@MeowMJ
Copy link
Collaborator

MeowMJ commented Nov 21, 2024

It seems that the folder /test/kernels is only useful in ICEDdeom.py. You already have CGRA-Benchmark in your CGRA-Flow and the 'fileSource' of ICEDdemo.py can be replaced with any folder path. Do we need to keep the folder /test/kernels?

@tancheng tancheng requested a review from HobbitQia November 21, 2024 17:28
@tancheng
Copy link
Owner Author

I tried to think about a cleaner way. However, the script hard-coded the path and has the pre-assumption about the file names. In addition, it is also reasonable to keep a set of test.cpp within the test folder, so we won't heavily depend on the cgra-benchmark's content (in case it is updated by itself).

In the future, our verification of the cgra-mapper can leverage the test/kernels.

@tancheng
Copy link
Owner Author

Hi @HobbitQia, can u plz help take a look at the failed test? Does it look like this time the offset of 2 is unnecessary?

@HobbitQia
Copy link
Collaborator

HobbitQia commented Nov 24, 2024

Hi @HobbitQia, can u plz help take a look at the failed test? Does it look like this time the offset of 2 is unnecessary?

u r right. I checked the opcode count in line 650-660 and I thought their original opcodes are correct. So this time we should set this paramter to be 0.🤔

@HobbitQia
Copy link
Collaborator

I saw u change the directory names from nonlinear_test, idiv_test to nonlinear, idiv. However, the working directories we set in cmake.yml are still ${{github.workspace}}/test/nonlinear_test, ${{github.workspace}}/test/idiv_test, respectively. I think it's the reason that the github testing failed.

@tancheng
Copy link
Owner Author

Right, I recognized that but forgot to push my fix. Thanks!

@tancheng tancheng merged commit b19c2bb into master Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants