-
-
Notifications
You must be signed in to change notification settings - Fork 807
- Migration of Objective-C code to Swift 5.0 #599
Conversation
- Addition of "apple.sh" shell script to generate a "Binary Framework" for iOS, iOS Simulator, Mac Catalyst and Mac OS plaforms. - Adoption of Cocoa design patters for Framework compatibility with Objective-C. - Addition of "apple-*.sh" scripts to support generation of libraries for Apple Intel (x86_64) and Apple Silicon (arm64) architectures. Scripts supports generation for platforms: macOS (Intel and Apple Silicon), Catalyst (Intel and Apple Silicon), iOS Simulator(Intel and Apple Silicon) and iOS (arm64). - Addition of Xcode project (MobileFFmpeg.xcodeproj) to support generation of Framework. New "apple.sh" script make use of this project to generate final individual Frameworks. Project can be integrated in other projects, or used to generate individual Framework for specific Platform/Architecture. - Project provide Test Unit with examples of new classes and methods. - Addition of Swift Package for distribution of final Binary Framework (XCFramework).
Thanks, it looks like a big PR. There are a lot of changes introduced in these files. Let me have a look at them. It will take time to understand how they work and whether we can merge them or not. |
Speaking as person working in Swift, I'm very excited about this! My current project isn't using FFMpeg because I put the one that does on the back burner in the hopes of this very thing eventually coming to be. Thank you! |
Your welcome,
I’m sorry if my explanation about the changes was to detailed, is just that in past experiences they asked me to explain as much I could, so they could understand the proposed changes.
… On Nov 25, 2020, at 2:44 PM, NCrusher ***@***.***> wrote:
Speaking as person working in Swift, I'm very excited about this! My current project isn't using FFMpeg because I put the one that does on the back burner in the hopes of this very thing eventually coming to be. Thank you!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I see some issues that make it difficult to merge this PR.
|
@jvega1976 Will you make a script to support tvOS as well? |
非常期待 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This project will be retired. Please consider switching to FFmpegKit. |
Hello,
Not sure if you could be interested, but I have migrated the iOS Objective-C code to Swift, so I'm contributing it in case you would like to use it for future releases.
Below is a short description of the multiple changes. I tried to not change the actual code, so I mostly copied (and sometimes renamed) the actual files (like the "ios-.sh" scripts, that I copied and renamed as "apple-.sh"); or the fftools C Language files that I copied to iOS/Sources/fftools (I did small changes in those files to enable full concurrent execution in Swift). New Swift files are located at ios/Sources/MobileFFmpeg. And the Xcode project is inside the ios folder.
In general these are the updates:
for iOS, iOS Simulator, Mac Catalyst and Mac OS plaforms.
for Apple Intel (x86_64) and Apple Silicon (arm64) architectures. Scripts supports
generation for platforms: macOS (Intel and Apple Silicon), Catalyst (Intel and Apple Silicon),
iOS Simulator(Intel and Apple Silicon) and iOS (arm64).
Framework. New "apple.sh" script make use of this project to generate
final individual Frameworks. Project can be integrated in other Xcode
projects, used for testing, or Frameworks generation for specific
Platform/Architecture.
(XCFramework).