IOS-3488 Letting signExternally throw exceptions #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Balashov152
approved these changes
May 2, 2023
tureck1y
reviewed
May 2, 2023
| } | ||
| return try! SigningOutput(serializedData: outputData) |
There was a problem hiding this comment.
а тут нужен try! ? Да и в целом может не писать try, раз у нас и так throws?
There was a problem hiding this comment.
try! сделан чтобы не пробрасывать наверх ошибки WalletCore, а только наши, от нашего сайнера.
Судя по тому, что в стандартной реализации все возможные исключения WalletCore перехватываются и обрабатываются через fatalError проблем тут быть не должно. Просто сделал чтобы было подобие стандартной реализации.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Подрефакторил чтобы не писать такое: