Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transformation motion blur #148

Merged
merged 20 commits into from
May 6, 2021
Merged

Transformation motion blur #148

merged 20 commits into from
May 6, 2021

Conversation

bareya
Copy link
Collaborator

@bareya bareya commented Apr 21, 2021 •
edited
Loading

This PR is to add support for multi-segment transformation motion blur. Currently motion blur is hard coded and set to 3 samples. Also it's controlled by environment variables. Main features:

  • Remove environment variables to control motion blur behaviour.
  • Motion blur always enabled on integrator's end.
  • Motion blur for each object is controlled individually through schema.
  • Adding HdCyclesTransformSource that is to be committed to HdCyclesResourceRegistry and resolved during HdCyclesDelegate::CommitResources process.

@bareya bareya self-assigned this Apr 21, 2021
@bareya bareya marked this pull request as draft April 21, 2021 20:34
@bareya bareya changed the title motion blur for meshes Mesh motion blur steps and deform Apr 28, 2021
@bareya bareya linked an issue Apr 28, 2021 that may be closed by this pull request
Multi-segment transformation and deformation motion blur #85
Closed
@bareya bareya added bug Something isn't working enhancement New feature or request technical debt labels Apr 28, 2021
@bareya bareya changed the title Mesh motion blur steps and deform Transformation motion blur Apr 29, 2021
@bareya bareya force-pushed the motion_blur_enhancement branch from 4b7e070 to 0aac1a7 Compare April 29, 2021 16:53
@bareya bareya linked an issue Apr 29, 2021 that may be closed by this pull request
Time varying attributes #140
Closed
@bareya bareya force-pushed the motion_blur_enhancement branch from c0219e0 to cc220e5 Compare April 30, 2021 00:05
@bareya bareya linked an issue May 3, 2021 that may be closed by this pull request
Synchronization between Cycles scene and primitives #89
Open
@bareya bareya force-pushed the motion_blur_enhancement branch 4 times, most recently from e38630e to 6b6057f Compare May 3, 2021 19:04
@bareya bareya removed a link to an issue May 4, 2021
Synchronization between Cycles scene and primitives #89
Open
@bareya bareya linked an issue May 4, 2021 that may be closed by this pull request
Synchronization between Cycles scene and primitives #89
Open
@bareya bareya mentioned this pull request May 4, 2021
Draft
@bareya bareya marked this pull request as ready for review May 5, 2021 01:06
bareya added 16 commits May 5, 2021 08:48
@bareya
Revert "motion blur for meshes"
ecba251 
This reverts commit 6b51905.
@bareya
remove old tests
2a4e590
@bareya
revert mistakenly removed render pass state
aa98428
@bareya
transform source keep raw point to object
3343ba8
@bareya
update transform source tests to raw object pointer
4f8ece5
@bareya
rename IndexedTime aliases, offset hash by resolution to avoid overfl…
be623db 
…owing
@bareya
Adding conditional ownership of of the ccl::Object to object source
1276d60
@bareya
Make resource registry non static. Resources have to be purged betwee…
58bbdc9 
…n render delegate's teardown.
@bareya
Add oversampling to HdCyclesTransformSource
a588b09
@bareya
fix float inf for segment width
717c44c
@bareya
updated resampling method that takes custom number of samples into an…
509e5b2 
… account
@bareya
fixing HdCyclesEnvValue constructor
03ddabf
@bareya
Environment variable motion blur override override
c63d538
@bareya
multi segment transformation motion blur for meshes
6b4d137
@bareya
schema update
3dd3c26
@bareya
rebase and reformat all
7c972e8
@bareya bareya force-pushed the motion_blur_enhancement branch from 1a647ca to 7c972e8 Compare May 5, 2021 16:07
@bareya bareya removed a link to an issue May 5, 2021
Synchronization between Cycles scene and primitives #89
Open
@bareya bareya merged commit d1bc60d into main May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boberfly boberfly Awaiting requested review from boberfly

@dedoardo dedoardo Awaiting requested review from dedoardo dedoardo is a code owner

@sergeneren sergeneren Awaiting requested review from sergeneren

@skwerner skwerner Awaiting requested review from skwerner skwerner is a code owner

@Vochsel Vochsel Awaiting requested review from Vochsel

Assignees

@bareya bareya

Labels
bug Something isn't working enhancement New feature or request technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time varying attributes Multi-segment transformation and deformation motion blur
1 participant
@bareya